Event Listener - Balance times 2

[lucastbucks]

Hi, I've got a weird issue and hope someone can help me with it.

I need to update the front end (wallets balance) using WebSockets.

I created my custom Wallet Update Event, but when the balance increments, it increments by 2. For example, if I transfer $1 from wallet A to wallet B, wallet A will be deducted $1 and wallet B will be credited $1. The database is fine. But when I get the value from $this->getBalance() or $this->wallet->balance, the value is 2. However, when I use $this->wallet->getAttributes(), the balance is 1.

And this only happens for transfers. Deposit gives me the right amount.

final class WalletUpdatedEvent implements BalanceUpdatedEventInterface, ShouldBroadcastNow
{
    use Dispatchable, InteractsWithSockets, SerializesModels;

    public function __construct(
        private readonly \Bavix\Wallet\Models\Wallet $wallet,
        private readonly DateTimeImmutable           $updatedAt,
    ) {}

    public function getWalletId(): int { return $this->wallet->getKey(); }
    public function getWalletUuid(): string { return $this->wallet->uuid; }
    public function getBalance(): string {
        return $this->wallet->balance;
    }
    public function getUpdatedAt(): DateTimeImmutable { return $this->updatedAt; }

    public function broadcastOn(): array
    {
        return [new Channel('wallets')];
    }

    public function getAttributes(): array
    {
        return $this->wallet->getAttributes();
    }

    public function broadcastWith(): array
    {
        logger()->info(print_r($this->wallet->getAttributes(), true));
        logger()->debug($this->getBalance());
        return [
            'wallet_id' => $this->getWalletId(),
            'wallet_uuid' => $this->getWalletUuid(),
            'balance' => (int) $this->getBalance(),
            'balance_float' => $this->wallet->balanceFloatNum,
            'slug' => $this->wallet->slug,
            'holder_id' => $this->wallet->holder_id,
            'updated_at' => $this->getUpdatedAt()->format('Y-m-d H:i:s'),
        ];
    }
}

This is the logs for depositing $100 to a user wallet.

[2024-06-09 23:10:48] local.INFO: Array
(
    [id] => 1
    [holder_type] => App\Models\User
    [holder_id] => 1
    [name] => User Wallet
    [slug] => user-wallet
    [uuid] => c4da82ac-a20a-45f3-bab6-2131b0dcbcb8
    [description] => 
    [meta] => []
    [balance] => 10000000
    [decimal_places] => 5
    [created_at] => 2024-06-07 03:30:38
    [updated_at] => 2024-06-09 23:10:23
    [deleted_at] => 
)
  
[2024-06-09 23:10:48] local.DEBUG: Balance: 10000000  

Now, if I transfer $1 from a user wallet to a campaign wallet:

[2024-06-09 23:12:37] local.INFO: Array
(
    [id] => 1
    [holder_type] => App\Models\User
    [holder_id] => 1
    [name] => User Wallet
    [slug] => user-wallet
    [uuid] => c4da82ac-a20a-45f3-bab6-2131b0dcbcb8
    [description] => 
    [meta] => []
    [balance] => 9900000
    [decimal_places] => 5
    [created_at] => 2024-06-07 03:30:38
    [updated_at] => 2024-06-09 23:10:48
    [deleted_at] => 
)
  
[2024-06-09 23:12:37] local.DEBUG: Balance: 9900000  
[2024-06-09 23:12:37] local.INFO: Array
(
    [id] => 1
    [holder_type] => App\Models\User
    [holder_id] => 1
    [name] => User Wallet
    [slug] => user-wallet
    [uuid] => c4da82ac-a20a-45f3-bab6-2131b0dcbcb8
    [description] => 
    [meta] => []
    [balance] => 9900000
    [decimal_places] => 5
    [created_at] => 2024-06-07 03:30:38
    [updated_at] => 2024-06-09 23:10:48
    [deleted_at] => 
)
  
[2024-06-09 23:12:37] local.DEBUG: Balance: 9900000  
[2024-06-09 23:12:37] local.DEBUG: array (
  'id' => 1,
  'holder_type' => 'App\\Models\\User',
  'holder_id' => 1,
  'name' => 'User Wallet',
  'slug' => 'user-wallet',
  'uuid' => 'c4da82ac-a20a-45f3-bab6-2131b0dcbcb8',
  'description' => NULL,
  'meta' => '[]',
  'balance' => '9900000',
  'decimal_places' => 5,
  'created_at' => '2024-06-07 03:30:38',
  'updated_at' => '2024-06-09 23:10:48',
  'deleted_at' => NULL,
)  
[2024-06-09 23:12:37] local.DEBUG: array (
  'wallet_id' => 1,
  'wallet_uuid' => 'c4da82ac-a20a-45f3-bab6-2131b0dcbcb8',
  'balance' => 9900000,
  'balance_float' => 99.0,
  'slug' => 'user-wallet',
  'holder_id' => 1,
  'updated_at' => '2024-06-09 23:12:37',
)  
[2024-06-09 23:12:37] local.INFO: Array
(
    [balance] => 100000
    [decimal_places] => 5
    [uuid] => b7b86d6e-9487-4d41-bc8c-9cea4d88ab08
    [name] => Campaign Funds
    [slug] => campaign-funds
    [holder_type] => App\Models\Campaign
    [holder_id] => 47
    [updated_at] => 2024-06-09 23:12:37
    [created_at] => 2024-06-09 23:12:37
    [id] => 140
)
  
[2024-06-09 23:12:37] local.DEBUG: Balance: 200000  
[2024-06-09 23:12:37] local.INFO: Array
(
    [balance] => 100000
    [decimal_places] => 5
    [uuid] => b7b86d6e-9487-4d41-bc8c-9cea4d88ab08
    [name] => Campaign Funds
    [slug] => campaign-funds
    [holder_type] => App\Models\Campaign
    [holder_id] => 47
    [updated_at] => 2024-06-09 23:12:37
    [created_at] => 2024-06-09 23:12:37
    [id] => 140
)
  
[2024-06-09 23:12:37] local.DEBUG: Balance: 200000  
[2024-06-09 23:12:37] local.DEBUG: array (
  'balance' => '100000',
  'decimal_places' => '5',
  'uuid' => 'b7b86d6e-9487-4d41-bc8c-9cea4d88ab08',
  'name' => 'Campaign Funds',
  'slug' => 'campaign-funds',
  'holder_type' => 'App\\Models\\Campaign',
  'holder_id' => 47,
  'updated_at' => '2024-06-09 23:12:37',
  'created_at' => '2024-06-09 23:12:37',
  'id' => 140,
)  
[2024-06-09 23:12:37] local.DEBUG: array (
  'wallet_id' => 140,
  'wallet_uuid' => 'b7b86d6e-9487-4d41-bc8c-9cea4d88ab08',
  'balance' => 200000,
  'balance_float' => 2.0,
  'slug' => 'campaign-funds',
  'holder_id' => 47,
  'updated_at' => '2024-06-09 23:12:37',
)  

The campaign wallet balance from $this->wallet->getAttributes() is 'balance' => '100000', but the balance from $this->wallet->balance is 'balance' => 200000,

There is one thing to notice: I'm transferring from a user with HasWallet to a campaign with HasWallets.

Any ideas or suggestions will be greatly appreciated..

Regards,
Lucas.

[rez1dent3]

Hello. Can I have the funds transfer code? Also, I need models.

[lucastbucks]

Sure,

Campaign Model:

class Campaign extends Model implements Wallet
{
    use HasFactory;
    use HasWalletFloat;
    use HasWallets;

    const string WALLET_PENDING = 'campaign-pending';
    const string WALLET_FUNDS = 'campaign-funds';
    const string WALLET_BONUS = 'campaign-bonus';

    protected $guarded = [];

public static function boot()
    {
        parent::boot();

        // Create dependencies
        static::created(function ($campaign) {
            // Create Stats
            $campaign->stats()->create();

            // Create wallets
            $campaign->createWallet([
                'name' => 'Campaign Funds',
                'slug' => self::WALLET_FUNDS,
            ]);

            $campaign->createWallet([
                'name' => 'Campaign Pending',
                'slug' => self::WALLET_PENDING,
            ]);

            $campaign->createWallet([
                'name' => 'Campaign Bonus',
                'slug' => self::WALLET_BONUS,
            ]);
        });
    }

}

When I create a new campaign I transfer from user funds to campaign funds:

class CampaignService
{
    private $user;

    public function __construct()
    {
        $this->user = Auth::user();
    }

public function create($data): Campaign
    {
        if (! $this->user->canWithdrawFloat($data->budget)) {
            throw new InsufficientFunds("User does not have enough funds to create campaign.", 0);
        }

        $campaign = new Campaign([
            'title' => $data->title,
            'internal_title' => $data->internal_title,
            'user_id' => Auth::id(),
            'instructions' => $data->instructions,
            'requirements' => $data->requirements,
            'thumbnail' => $data->thumbnail,
            'hourly_submission_limit' => $data->hourly_submission_limit,
            'hourly_spending_limit' => $data->hourly_spending_limit,
            'daily_submission_limit' => $data->daily_submission_limit,
            'daily_spending_limit' => $data->daily_spending_limit,
            'category_type' => $data->category_type,
            'frequency' => $data->frequency,
            'gender' => $data->gender,
            'age_from' => $data->age_from,
            'age_to' => $data->age_to,
            'approval_time' => $data->approval_time,
            'min_time' => $data->min_time,
            'proof_type' => $data->proof_type,
            'external_id' => Str::uuid()
        ]);

        if (! $campaign->save()) {
            throw new \Exception("Failed to create campaign."); // TODO: Make unique exceptions
        }

        if (! $campaign->hasWallet('campaign-funds')) {
            throw new \Exception("Campaign funds wallet not found.");
        }

        // Get funds wallet
        $fundsWallet = $campaign->getWallet('campaign-funds');

        // Transfer funds from user wallet to campaign wallet
        $this->user->transferFloat($fundsWallet, $data->budget);

        return $campaign;
    }

}

User Model I only implement HasWallet:

class User extends Authenticatable implements MustVerifyEmail, Wallet, WalletFloat
{
    use HasApiTokens;
    use HasFactory;
    use HasProfilePhoto;
    use HasTeams;
    use Notifiable;
    use TwoFactorAuthenticatable;
    use HasWalletFloat;
   
   // ...
}

Listener:

class WalletUpdatedListener
{
    /**
     * Create the event listener.
     */
    public function __construct()
    {
        //
    }

    /**
     * Handle the event.
     */
    public function handle(BalanceUpdatedEventInterface $event): void
    {
        $walletData = $event->broadcastWith();
        Redis::set('wallet:' . $walletData['slug'] . ':' . $walletData['holder_id'], json_encode($walletData));
        logger($event->getAttributes());
        logger($walletData);
    }
}

Event:

final class WalletUpdatedEvent implements BalanceUpdatedEventInterface, ShouldBroadcastNow
{
    use Dispatchable, InteractsWithSockets, SerializesModels;

    public function __construct(
        private readonly \Bavix\Wallet\Models\Wallet $wallet,
        private readonly DateTimeImmutable           $updatedAt,
    ) {}

    public function getWalletId(): int { return $this->wallet->getKey(); }
    public function getWalletUuid(): string { return $this->wallet->uuid; }
    public function getBalance(): string {
        return $this->wallet->balance;
    }
    public function getUpdatedAt(): DateTimeImmutable { return $this->updatedAt; }

    public function broadcastOn(): array
    {
        return [new Channel('wallets')];
    }

    public function getAttributes(): array
    {
        return $this->wallet->getAttributes();
    }

    public function broadcastWith(): array
    {
        logger()->info(print_r($this->wallet->getAttributes(), true));
        logger()->debug("Balance: " . $this->getBalance());
        return [
            'wallet_id' => $this->getWalletId(),
            'wallet_uuid' => $this->getWalletUuid(),
            'balance' => (int) $this->getBalance(),
            'balance_float' => $this->wallet->balanceFloatNum,
            'slug' => $this->wallet->slug,
            'holder_id' => $this->wallet->holder_id,
            'updated_at' => $this->getUpdatedAt()->format('Y-m-d H:i:s'),
        ];
    }
}

Assembler:

class WalletUpdatedEventAssembler implements BalanceUpdatedEventAssemblerInterface
{
    public function create(\Bavix\Wallet\Models\Wallet $wallet) : \Bavix\Wallet\Internal\Events\BalanceUpdatedEventInterface
    {
        return new WalletUpdatedEvent($wallet, new DateTimeImmutable());
    }
}

Thanks in advance.
Lucas.

[rez1dent3]

Thank you. I'll try to reproduce your case this weekend, if possible.

[lucastbucks]

Thanks man, really appreciate that.

[rez1dent3]

@lucastbucks You need to get your balance like this:

final class WalletUpdatedEvent implements BalanceUpdatedEventInterface, ShouldBroadcastNow
{
    use Dispatchable, InteractsWithSockets, SerializesModels;
....
    public function getBalance(): string {
-        return $this->wallet->balance;
+        return $this->wallet->getOriginalBalanceAttribute();
    }
    ....

I think this will solve your problem. Please write the result.

From source:

laravel-wallet/src/Internal/Assembler/BalanceUpdatedEventAssembler.php

Lines 19 to 27 in d8c2ad8

	public function create(Wallet $wallet): BalanceUpdatedEventInterface
	{
	return new BalanceUpdatedEvent(
	$wallet->getKey(),
	$wallet->uuid,
	$wallet->getOriginalBalanceAttribute(),
	$this->clockService->now()
	);
	}

[lucastbucks]

@rez1dent3 Hey man, yes it does fix the problem!

I've added into my Custom Wallet Class:

public function getOriginalBalanceFloatAttribute(): string
    {
        return app(FormatterServiceInterface::class)->floatValue(
            $this->getOriginalBalanceAttribute(),
            $this->decimal_places,
        );
    }

    public function getOriginalBalanceFloatNumAttribute(): float
    {
        return (float) $this->getOriginalBalanceFloatAttribute();
    }

I'm not sure if that's the best way to do it but works for now.

Thanks for the help!
Lucas.