Update 'Allow Optim.Options to pass to BAT.find_mode'

[Micki-D]

This updates PR #423 to the current main branch.

[Micki-D]

I created a new PR, since I thought this would be cleaner than changing PR #423. Let me know if I should do it the other way.

[codecov]

Codecov Report

Attention: Patch coverage is 76.31579% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 47.41%. Comparing base (67ac2bf) to head (dc9112e).

Files	Patch %	Lines
ext/BATOptimizationExt.jl	69.23%	8 Missing ⚠️
ext/BATOptimExt.jl	91.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
+ Coverage   47.26%   47.41%   +0.15%     
==========================================
  Files         111      112       +1     
  Lines        5385     5418      +33     
==========================================
+ Hits         2545     2569      +24     
- Misses       2840     2849       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[oschulz]

I created a new PR,

That's fine!

[Micki-D]

I am confused about the Julia 1.6-ubuntu-latest tests failing.
In the compilation of the environment, it gives a warning that the exact package versions could not be loaded, and indeed, when comparing the compiled package versions to the other test runs that pass, the failing one has different versions.
Most are lower versions, but there are some higher versions than in the passing test.

Could there be some issue with the job setup?

[oschulz]

@Micki-D can you try to run tests manually on v1.6?

[oschulz]

Why did you close this one @Micki-D ?

[Micki-D]

Ah beans. I did not mean to do so. I'll reopen this @oschulz .