chore: update deps and configs

- Remove TypeScript config `noImplicitAny` and `noImplicitTHis`.
  They are both enabled under `strict` in TSC >=5.0

- Remove `noUnusedLocals`: this should be checked by a linter.

- Enable skipLibCheck (recommended by TSC)

- Remove stripInternal (no use)

- Add tsconfig and rome $schema for auto-completion in IDE

- Remove `npx` in scripts: it incurs a 30% slowdown.

- Specify `--target` for _ESbuild_.
  _ESbuild_ >= 0.18.0 no longer relies on `tsconfig`'s `target` option.

- Enable all Rome rules and make sure that generated code will pass
  all rules.

- Disable Rome `json` formatting

package.json

@@ -57,15 +57,15 @@
   },
   "devDependencies": {
     "@bare-ts/lib": "~0.3.0",
-    "@types/node": "~14.18.0",
-    "esbuild": "0.17.5",
-    "oletus": "3.3.0",
-    "rome": "11.0.0-nightly.fab5440",
-    "typescript": "5.0.0-beta",
+    "@types/node": "~14.18.49",
+    "esbuild": "0.18",
+    "oletus": "4.0.0",
+    "rome": "12.1.3",
+    "typescript": "5.1.3",
     "validate-commit-message": "3.2.0"
   },
   "dependencies": {
-    "commander": "10.0.0"
+    "commander": "10.0.1"
   },
   "peerDependencies": {
     "@bare-ts/lib": "~0.3.0"

rome.json

@@ -1,18 +1,26 @@
 {
+  "$schema": "./node_modules/rome/configuration_schema.json",
   "formatter": {
     "indentStyle": "space",
-    "indentSize": 4
+    "indentSize": 4,
+    "ignore": ["*.json", "./tsconfig-base.json"]
   },
   "linter": {
     "enabled": true,
     "rules": {
-      "recommended": true
+      "all": true,
+      "nursery": {
+        "useLiteralKeys": "off"
+      }
     }
   },
   "javascript": {
     "formatter": {
       "quoteProperties": "preserve",
       "semicolons": "asNeeded"
     }
+  },
+  "organizeImports": {
+    "enabled": true
   }
 }

scripts/build.sh

@@ -1,19 +1,23 @@
 #!/bin/sh
 set -eu
 
+# https://node.green/#ES2020
+# https://kangax.github.io/compat-table/es2016plus
+TARGET=es2020
+
 # build .d.ts
-npx tsc --build src
+tsc --build src/
 
 cp -f dist/index.d.ts dist/index.d.cts
 
 # build ESM
-npx esbuild src/index.ts src/*/*.ts --outdir=dist --log-level=warning
+esbuild src/index.ts src/*/*.ts --target=$TARGET --outdir=dist --log-level=warning
 
 # build CommonJS (fallback)
-npx esbuild src/index.ts --bundle --platform=node > dist/index.cjs
+esbuild src/index.ts --bundle --target=$TARGET --platform=node > dist/index.cjs
 
 # build cli (bin)
-npx esbuild src/cli.ts --define:VERSION=\""$npm_package_version"\" > dist/cli.js
+esbuild src/cli.ts --target=$TARGET --define:VERSION=\""$npm_package_version"\" > dist/cli.js
 
 # build standalone cli program
-npx esbuild dist/cli.js --bundle --minify --keep-names --platform=node > dist/bare
+esbuild dist/cli.js --bundle --target=$TARGET --minify --keep-names --platform=node > dist/bare

scripts/generate-tests-corpus.js

@@ -1,6 +1,6 @@
 #!/usr/bin/env node
 
-import { Config, configure, transform, parse } from "@bare-ts/tools"
+import { Config, configure, parse, transform } from "@bare-ts/tools"
 import * as fs from "node:fs"
 import * as path from "node:path"
 

scripts/test.sh

@@ -1,14 +1,13 @@
 #!/bin/sh
-set -eu
 
-npm run build
+. scripts/build.sh
 
 # unit tests
-npx oletus dist/*/*.test.js tests-corpus/*.test.js tests-corpus/*/*/*.test.js
+oletus dist/*/*.test.js tests-corpus/*.test.js tests-corpus/*/*/*.test.js
 
 # lint
-npx rome ci src scripts
-npx rome check tests-corpus
+rome ci src scripts
+rome check tests-corpus
 
 # type check
-npx tsc --build src/tsconfig-*.json tests-corpus
+tsc --build src/tsconfig-test.json tests-corpus/

src/cli.ts

@@ -3,10 +3,10 @@
 //! Copyright (c) 2022 Victorien Elvinger
 //! Licensed under the MIT License (https://mit-license.org/)
 
+import { Config, transform } from "./index.js"
 import { Argument, Option, program } from "commander"
 import * as fs from "node:fs"
 import * as process from "node:process"
-import { Config, transform } from "./index.js"
 
 // WARNING: This constant MUST be defined at build time.
 declare const VERSION: string

src/generator/js-generator.ts

@@ -74,9 +74,6 @@ export function generate(schema: ast.Ast, config: Config): string {
         }
     }
     let head = ""
-    if (/\bassert\(/.test(body)) {
-        head += 'import assert from "assert"\n'
-    }
     if (/bare\./.test(body)) {
         head += // Are values imported?
             g.config.generator !== "ts" ||
@@ -85,8 +82,11 @@ export function generate(schema: ast.Ast, config: Config): string {
                 ? 'import * as bare from "@bare-ts/lib"\n'
                 : 'import type * as bare from "@bare-ts/lib"\n'
     }
+    if (/\bassert\(/.test(body)) {
+        head += 'import assert from "node:assert"\n'
+    }
     if (/ext\./.test(body)) {
-        head += 'import * as ext from "./ext.js"\n'
+        head += '\nimport * as ext from "./ext.js"\n'
     }
     if (
         hasEncodeDecode &&
@@ -918,9 +918,10 @@ function genBaseFlatUnionWriter(g: Gen, union: ast.UnionType): string {
         const type = union.types[i]
         if (type.tag === "void") {
             defaultCase = `
-            default:
+            default: {
                 bare.${tagWriter}(bc, ${tagVal})
-                break`
+                break
+            }`
         } else {
             const valWriting = genWriting(g, type, "$x")
             switchBody += `

src/parser/bare-parser.ts

@@ -2,8 +2,8 @@
 //! Licensed under the MIT License (https://mit-license.org/)
 
 import * as ast from "../ast/bare-ast.js"
-import type { Config } from "../core/config.js"
 import { CompilerError, type Location } from "../core/compiler-error.js"
+import type { Config } from "../core/config.js"
 import { Lex } from "./bare-lex.js"
 
 export function parse(content: string, config: Config): ast.Ast {

src/tsconfig-test.json

@@ -1,9 +1,8 @@
 {
   "extends": "../tsconfig-base.json",
   "compilerOptions": {
-    "moduleResolution": "node",
     "types": ["node"]
   },
-  "include": ["./**/*.test.ts"],
+  "include": ["./cli.ts", "./**/*.test.ts"],
   "references": [{ "path": "." }]
 }

src/tsconfig.json

@@ -7,6 +7,5 @@
 
     "composite": true
   },
-  "include": ["./**/*.ts"],
   "exclude": ["./cli.ts", "./**/*.spec.ts", "./**/*.test.ts"]
 }

tests-corpus/tsconfig.json

@@ -1,10 +1,7 @@
 {
   "extends": "../tsconfig-base.json",
   "compilerOptions": {
-    "moduleResolution": "node",
-    "paths": { "@bare-ts/tools": ["../src/index.js"] },
     "types": ["node"]
   },
-  "include": ["./**/*.js", "./**/*.ts"],
   "references": [{ "path": "../src/" }]
 }

tests-corpus/valid-bare-schema/data-fixed-legacy/out.gen.js

@@ -1,5 +1,5 @@
-import assert from "assert"
 import * as bare from "@bare-ts/lib"
+import assert from "node:assert"
 
 const config = /* @__PURE__ */ bare.Config({})
 

tests-corpus/valid-bare-schema/data-fixed-legacy/out.gen.ts

@@ -1,5 +1,5 @@
-import assert from "assert"
 import * as bare from "@bare-ts/lib"
+import assert from "node:assert"
 
 const config = /* @__PURE__ */ bare.Config({})
 

tests-corpus/valid-bare-schema/data-fixed/out.gen.js

@@ -1,5 +1,5 @@
-import assert from "assert"
 import * as bare from "@bare-ts/lib"
+import assert from "node:assert"
 
 const config = /* @__PURE__ */ bare.Config({})
 

tests-corpus/valid-bare-schema/data-fixed/out.gen.ts

@@ -1,5 +1,5 @@
-import assert from "assert"
 import * as bare from "@bare-ts/lib"
+import assert from "node:assert"
 
 const config = /* @__PURE__ */ bare.Config({})
 

tests-corpus/valid-bare-schema/imported-config/out.gen.js

@@ -1,4 +1,5 @@
 import * as bare from "@bare-ts/lib"
+
 import * as ext from "./ext.js"
 
 export function readMessage(bc) {

tests-corpus/valid-bare-schema/imported-config/out.gen.ts

@@ -1,4 +1,5 @@
 import * as bare from "@bare-ts/lib"
+
 import * as ext from "./ext.js"
 
 export type u8 = number

tests-corpus/valid-bare-schema/list-fixed-leading-0/out.gen.js

@@ -1,5 +1,5 @@
-import assert from "assert"
 import * as bare from "@bare-ts/lib"
+import assert from "node:assert"
 
 const config = /* @__PURE__ */ bare.Config({})
 

tests-corpus/valid-bare-schema/list-fixed-leading-0/out.gen.ts

@@ -1,5 +1,5 @@
-import assert from "assert"
 import * as bare from "@bare-ts/lib"
+import assert from "node:assert"
 
 const config = /* @__PURE__ */ bare.Config({})
 

tests-corpus/valid-bare-schema/list-fixed-legacy/out.gen.js

@@ -1,5 +1,5 @@
-import assert from "assert"
 import * as bare from "@bare-ts/lib"
+import assert from "node:assert"
 
 const config = /* @__PURE__ */ bare.Config({})
 

tests-corpus/valid-bare-schema/list-fixed-legacy/out.gen.ts

@@ -1,5 +1,5 @@
-import assert from "assert"
 import * as bare from "@bare-ts/lib"
+import assert from "node:assert"
 
 const config = /* @__PURE__ */ bare.Config({})
 

tests-corpus/valid-bare-schema/list-fixed/out.gen.js

@@ -1,5 +1,5 @@
-import assert from "assert"
 import * as bare from "@bare-ts/lib"
+import assert from "node:assert"
 
 const config = /* @__PURE__ */ bare.Config({})
 

tests-corpus/valid-bare-schema/list-fixed/out.gen.ts

@@ -1,5 +1,5 @@
-import assert from "assert"
 import * as bare from "@bare-ts/lib"
+import assert from "node:assert"
 
 const config = /* @__PURE__ */ bare.Config({})
 

tests-corpus/valid-bare-schema/list-union-circular-ref/out.gen.js

@@ -1,5 +1,5 @@
-import assert from "assert"
 import * as bare from "@bare-ts/lib"
+import assert from "node:assert"
 
 function read0(bc) {
     const offset = bc.offset

tests-corpus/valid-bare-schema/list-union-circular-ref/out.gen.ts

@@ -1,5 +1,5 @@
-import assert from "assert"
 import * as bare from "@bare-ts/lib"
+import assert from "node:assert"
 
 function read0(bc: bare.ByteCursor): 
     | { readonly tag: "Alias", readonly val: Alias }

tests-corpus/valid-bare-schema/typed-array-fixed/out.gen.js

@@ -1,5 +1,5 @@
-import assert from "assert"
 import * as bare from "@bare-ts/lib"
+import assert from "node:assert"
 
 const config = /* @__PURE__ */ bare.Config({})
 

tests-corpus/valid-bare-schema/typed-array-fixed/out.gen.ts

@@ -1,5 +1,5 @@
-import assert from "assert"
 import * as bare from "@bare-ts/lib"
+import assert from "node:assert"
 
 const config = /* @__PURE__ */ bare.Config({})
 

tests-corpus/valid-bare-schema/union-composite-type/out.gen.js

@@ -1,5 +1,5 @@
-import assert from "assert"
 import * as bare from "@bare-ts/lib"
+import assert from "node:assert"
 
 const config = /* @__PURE__ */ bare.Config({})
 

tests-corpus/valid-bare-schema/union-composite-type/out.gen.ts

@@ -1,5 +1,5 @@
-import assert from "assert"
 import * as bare from "@bare-ts/lib"
+import assert from "node:assert"
 
 const config = /* @__PURE__ */ bare.Config({})
 

tests-corpus/valid-bare-schema/union-flat-typeof/out.gen.js

@@ -38,9 +38,10 @@ export function writeTypeOfUnion(bc, x) {
             bare.writeString(bc, x)
             break
         }
-        default:
+        default: {
             bare.writeU8(bc, 3)
             break
+        }
     }
 }
 

tests-corpus/valid-bare-schema/union-flat-typeof/out.gen.ts

@@ -46,9 +46,10 @@ export function writeTypeOfUnion(bc: bare.ByteCursor, x: TypeOfUnion): void {
             bare.writeString(bc, x)
             break
         }
-        default:
+        default: {
             bare.writeU8(bc, 3)
             break
+        }
     }
 }
 

tests-corpus/valid-bare-schema/x-bareorg-example/out.gen.js

@@ -1,5 +1,5 @@
-import assert from "assert"
 import * as bare from "@bare-ts/lib"
+import assert from "node:assert"
 
 const config = /* @__PURE__ */ bare.Config({})
 

tests-corpus/valid-bare-schema/x-bareorg-example/out.gen.ts

@@ -1,5 +1,5 @@
-import assert from "assert"
 import * as bare from "@bare-ts/lib"
+import assert from "node:assert"
 
 const config = /* @__PURE__ */ bare.Config({})
 

tests-corpus/valid-bare-schema/x-bareorg-example/user.test.js

@@ -2,7 +2,8 @@
 //! Licensed under the MIT License (https://mit-license.org/)
 
 import { default as test } from "oletus"
-import { decodePerson, encodePerson, Department } from "./out.gen.js"
+
+import { Department, decodePerson, encodePerson } from "./out.gen.js"
 
 test("x-readme-example", (t) => {
     const payload1 = encodePerson({

tests-corpus/valid-bare-schema/x-readme-example/user.test.js

@@ -2,7 +2,8 @@
 //! Licensed under the MIT License (https://mit-license.org/)
 
 import { default as test } from "oletus"
-import { decodeContacts, encodeContacts, Gender } from "./out.gen.js"
+
+import { Gender, decodeContacts, encodeContacts } from "./out.gen.js"
 
 test("x-readme-example", (t) => {
     const payload = encodeContacts([