Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move coingecko settings from token prices file to config #439

Merged
merged 1 commit into from
May 23, 2023

Conversation

timjrobinson
Copy link
Contributor

@timjrobinson timjrobinson commented May 19, 2023

Moving Coingecko platformId and nativeAssetId to the config files instead of being inside coingecko, so that these settings aren't missed when adding a new network. Also added settings for zkevm.

Copy link
Member

@johngrantuk johngrantuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good improvement. Thanks!

@johngrantuk johngrantuk merged commit 47a4538 into develop May 23, 2023
@johngrantuk johngrantuk deleted the move-coingecko-to-config branch May 23, 2023 08:50
@johngrantuk johngrantuk mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants