-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Relayer V5 #401
Add Relayer V5 #401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, balancerRelayerInterface encoding needs to be updated here as well: https://github.com/balancer/balancer-sdk/blob/develop/balancer-js/src/modules/swaps/joinAndExit.ts/#L1052-L1055
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also add RelayerV5 to src/modules/contracts/implementations/relayer.ts
and make sure we're using most recent contract in tests, examples, etc.
This file was one of the reasons I asked if we should keep instantiating as Contract types or as RelayerV5 type. I chose to instantiate as RelayerV5 directly on contracts.module.ts. |
I can't remember the original reason TBH. Looks like some have some additional logic. I think if we're keeping them then we should update to include V5 to keep consistency. If we're removing them then it might be better to do it in another PR. |
15773550 | ||
); | ||
|
||
// Removed test that started failing after updating to a more recent blockNumber |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to update to a more recent block due to relayerV5 and this test started failing. I tried figuring out why, but it was taking too long and I decided it would be better to check before spending more time on it.
@johngrantuk - this was the only test with a custom blockNumber - do you remember why that was the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't actually remember. I wanted to work on refactoring joinAndExits a bit next week so can investigate then. Should be ok to ignore for now.
Note: relayer addresses were taken from here