Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Simplified Click and DoubleClick overloads #755

Closed
wants to merge 3 commits into from
Closed

Conversation

linkdotnet
Copy link
Sponsor Collaborator

Pull request description

The PR addresses and implements #617. Also I created a small breaking-changes.md so that we can keep track what we have to provide for a migration documentation from v1 -> v2. We could also directly have a section in the documentation if you want.

Alternatively we only work with the commit messages to derive which changes are breaking.

@linkdotnet linkdotnet requested a review from egil June 16, 2022 07:00
@linkdotnet
Copy link
Sponsor Collaborator Author

I guess I'd take the inititave in remove all of the "convenient" overloads.
Not only in MouseEventDispatchExtensions but in all others as well. What's your thought on this one @egil ?

@linkdotnet
Copy link
Sponsor Collaborator Author

I added the change with the last commit. Let me know your thoughts. Will check the tests

@egil
Copy link
Member

egil commented Jun 16, 2022

I actually want to hold off on this for a bit, since we might not need these methods in their current form. With #48, the triggering of event handlers could end up being handled by AngleSharps implementation of event bubbling in C#. At the very least it will change our implementation, so I think we need to table this for now. Lets keep this code around though, but wait to merge until we know the fate of the helpers.

@linkdotnet
Copy link
Sponsor Collaborator Author

Sounds good. I will least close the PR and keep the branch. If we need something from this branch we dig it out again ;)

@linkdotnet linkdotnet closed this Jun 16, 2022
@linkdotnet linkdotnet deleted the feature/#617 branch November 17, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants