Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use Microsoft Graph and modern azuread provider #1255

Closed
wants to merge 18 commits into from

Conversation

arnaudlh
Copy link
Member

Issue-id

PR Checklist


Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@arnaudlh arnaudlh self-assigned this Jul 18, 2022
@arnaudlh arnaudlh added enhancement New feature or request azuread labels Jul 18, 2022
@arnaudlh arnaudlh changed the title Update to use Microsoft Graph and modern azureadprovider Update to use Microsoft Graph and modern azuread provider Jul 18, 2022
@EmilMunksoe
Copy link

Hi @arnaudlh and @LaurentLesle. Can we move this MR through review soon. This is stopping me from migrating part of my terraform code to use CAF module. And also if possible, update the provider dependency to 2.28.1, which is the newest https://registry.terraform.io/providers/hashicorp/azuread/latest

}
}
dynamic "required_resource_access" {
for_each = try(var.settings.required_resource_access, null) != null ? [var.settings.required_resource_access] : []

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to pass in a list of "required_resource_access" instead of just one object.

for_each = try(var.settings.required_resource_access_list, [])

content {
resource_app_id = can(required_resource_access.value.resource_app.id) ? required_resource_access.value.resource_app.id : data.azuread_application_published_app_ids.well_known.result[required_resource_access.value.resource_app.well_known_key]
dynamic "resource_access" {
for_each = try(required_resource_access.value.resource_access, null) != null ? [required_resource_access.value.resource_access] : []

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to pass in a list of "resource_access" instead of just one object

for_each = try(required_resource_access.value.resource_access_list, [])

@happyelegance
Copy link

Hi @arnaudlh and @LaurentLesle, I second @EmilMunksoe's sentiment. Are you planning on merging this PR some time soon? We are also looking to upgrade some of our azuread code to CAF and this is blocking us.

@arnaudlh
Copy link
Member Author

Closing as integration will happen in int-5.7.0

@arnaudlh arnaudlh closed this Mar 24, 2023
@arnaudlh arnaudlh deleted the sm-azuread_graph branch January 9, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azuread enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Unable to use this module with azuread resources
6 participants