-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use Microsoft Graph and modern azuread provider #1255
Conversation
Added 'assignable_to_role' option for AAD groups
Hi @arnaudlh and @LaurentLesle. Can we move this MR through review soon. This is stopping me from migrating part of my terraform code to use CAF module. And also if possible, update the provider dependency to 2.28.1, which is the newest https://registry.terraform.io/providers/hashicorp/azuread/latest |
} | ||
} | ||
dynamic "required_resource_access" { | ||
for_each = try(var.settings.required_resource_access, null) != null ? [var.settings.required_resource_access] : [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to pass in a list of "required_resource_access" instead of just one object.
for_each = try(var.settings.required_resource_access_list, [])
content { | ||
resource_app_id = can(required_resource_access.value.resource_app.id) ? required_resource_access.value.resource_app.id : data.azuread_application_published_app_ids.well_known.result[required_resource_access.value.resource_app.well_known_key] | ||
dynamic "resource_access" { | ||
for_each = try(required_resource_access.value.resource_access, null) != null ? [required_resource_access.value.resource_access] : [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to pass in a list of "resource_access" instead of just one object
for_each = try(required_resource_access.value.resource_access_list, [])
Hi @arnaudlh and @LaurentLesle, I second @EmilMunksoe's sentiment. Are you planning on merging this PR some time soon? We are also looking to upgrade some of our azuread code to CAF and this is blocking us. |
Closing as integration will happen in |
Issue-id
PR Checklist
Description
Does this introduce a breaking change
Testing