logreader: fix spurious wakeups by updating the suspended flag on I/O poll #299
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… poll Signed-off-by: László Várady <laszlo.varady@anno.io>
alltilla
approved these changes
Sep 23, 2024
| @@ -335,6 +335,7 @@ log_reader_update_watches(LogReader *self) | |||
| switch (prepare_action) | |||
| { | |||
| case LPPA_POLL_IO: | |||
| self->suspended = FALSE; | |||
There was a problem hiding this comment.
[nitpick/question]
Although LPPA_POLL_IO was the only case where setting/unsetting self->suspended was missing, I feel like the truthy state of self->suspended is not decided at this point, but earlier at free_to_send. Of course ProtoServer can override it with LPPA_SUSPEND, but as soon as log_source_free_to_send() returns true, we could set self->suspended to false. Am I understanding this right?
This is just a strange feeling though, I think everything is behaving as expected with your change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.