feat: support keywords in npm installer #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadows-withal
commented
Apr 25, 2023
| pub app_homepage_url: Option<String>, | ||
| /// A list of the app's keywords | ||
| pub app_keywords: Option<Vec<String>>, |
There was a problem hiding this comment.
I don't even think adding this to the DistGraph was necessary, but I figured it'd be good future-proofing in case we mess around with stuff outside of npm
Gankra
approved these changes
Apr 25, 2023
| pub app_homepage_url: Option<String>, | ||
| /// A list of the app's keywords | ||
| pub app_keywords: Option<Vec<String>>, |
This was referenced May 3, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #220. I hope I caught all the necessary places keywords needed to be shoehorned in? It looks right to me.