Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add acknowledgement mode on @SqsListener annotation #870

Merged
merged 11 commits into from
Nov 4, 2023
Merged

Add acknowledgement mode on @SqsListener annotation #870

merged 11 commits into from
Nov 4, 2023

Commits on Aug 21, 2023

  1. Add ack mode parameter to SqsListener annotation 

    Fixes awspringgh-761
    @jvcalassio
    jvcalassio committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    23f13c6 View commit details
    Browse the repository at this point in the history

  2. Remove unrelated file from PR

    @jvcalassio
    jvcalassio committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    ab48691 View commit details
    Browse the repository at this point in the history

  3. Fix style differences

    @jvcalassio
    jvcalassio committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    9712fd0 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Rename acknowledgement enum to be consistent with other nomenclatures

    @jvcalassio
    jvcalassio committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    b94c432 View commit details
    Browse the repository at this point in the history

  2. Update docs with @SqsListener acknowledgement mode param

    @jvcalassio
    jvcalassio committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    a11d16c View commit details
    Browse the repository at this point in the history

  3. Add JavaDoc for method and test enum value 

    - Added missing JavaDoc for getAcknowledgementMode public method
- Added test to ensure that new SqsListenerAcknowledgementMode enum will
  have the same values as the original AcknowledgementMode enum
    @jvcalassio
    jvcalassio committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    895aca1 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Change annotation ack from enum to string 

    - Change SqsListenerAcknowledgementMode from enum to class with const
  strings
- Change typo on "acknowledgement" annotation field
- Remove unnecessary field on SqsContainerOptionsBuilder
- Move integration tests to its own test suite
    @jvcalassio
    jvcalassio committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    5b5eac3 View commit details
    Browse the repository at this point in the history

  2. Update documentation and code comments 

    - Update docs to reflect new "DEFAULT" annotation ack mode
- Update comments with latest changes
    @jvcalassio
    jvcalassio committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    24e5a80 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Set empty string as default behavior 

    - Remove "DEFAULT" annotation acknowledgement mode, use empty string as
  default
- Update docs
    @jvcalassio
    jvcalassio committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    69910c7 View commit details
    Browse the repository at this point in the history

  2. Add author after latest changes 

    - Add author on modified classes
    @jvcalassio
    jvcalassio committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    7570c16 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Fix inverted condition when resolving AcknowledgementMode value

    @jvcalassio
    jvcalassio committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    fab5d97 View commit details
    Browse the repository at this point in the history