Add S3Client listObjects support in S3Template #831
Conversation
alexisgra
requested review from
maciejwalkowiak,
MatejNedic and
tomazfernandes
as code owners
...arent/spring-cloud-aws-s3/src/test/java/io/awspring/cloud/s3/S3TemplateIntegrationTests.java
Outdated
Show resolved
Hide resolved
|
Thanks @alexisgra for contribution and @kunalvarpe for taking your time to review! |
|
|
||
| /** | ||
| * Returns some or all (up to 1,000) of the objects in a bucket. | ||
| * Does not handle pagination. If you need pagination you should use {@link S3PathMatchingResourcePatternResolver} or {@link S3Client} |
There was a problem hiding this comment.
Maybe we should include a paginator request since it will paginate if there are more than 1000 objects internally ->
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/s3/S3Client.html#listObjectsV2Paginator(software.amazon.awssdk.services.s3.model.ListObjectsV2Request)
There was a problem hiding this comment.
According to the issue I used as a reference: #767 . It is specified that in the S3Template, pagination would not be managed on the list objects. If you need pagination, you should use the S3Client or S3PathMatchingResourcePatternResolver according to the issue.
I can manage the pagination if required. Thanks.
📢 Type of change
📜 Description
I've added the listObjects operation in S3Template.
💡 Motivation and Context
It fixes the issue : #767
💚 How did you test it?
I added an integration test in S3TemplateIntegrationTests.
📝 Checklist
🔮 Next steps