Add support for autoStartup #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcinmilewski93
requested review from
maciejwalkowiak,
MatejNedic and
tomazfernandes
as code owners
github-actions
bot
added
component: sqs
tomazfernandes
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Sorry for the delay, PR looks perfect @marcinmilewski93, thanks!
I'll just give @maciejwalkowiak a chance to take a look before merging.
tomazfernandes
added
type: feature
This was referenced Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
I added a new SqsContainerOption
autoStartupboolean which is used to override the methodisAutoStartup()from theSmartLifeCycleinterface.💡 Motivation and Context
#818
It is needed in my service where Listener may not have to be active on the startup.
💚 How did you test it?
📝 Checklist
🔮 Next steps