Add manual container instantiation sample #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcruzdev
requested review from
maciejwalkowiak,
MatejNedic and
tomazfernandes
as code owners
9 tasks
tomazfernandes
requested changes
May 4, 2023
There was a problem hiding this comment.
Same, thanks again @mcruzdev! Let me know if the comments make sense to you.
...sample/src/main/java/io/awspring/cloud/sqs/sample/SqsManualContainerInstantiationSample.java
Outdated
Show resolved
Hide resolved
...sample/src/main/java/io/awspring/cloud/sqs/sample/SqsManualContainerInstantiationSample.java
Outdated
Show resolved
Hide resolved
...sample/src/main/java/io/awspring/cloud/sqs/sample/SqsManualContainerInstantiationSample.java
Outdated
Show resolved
Hide resolved
...sample/src/main/java/io/awspring/cloud/sqs/sample/SqsManualContainerInstantiationSample.java
Outdated
Show resolved
Hide resolved
|
Hi @tomazfernandes , can you review this pull request? |
tomazfernandes
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This pull request adds a new sample for SQS, in other words this add a sample showing how can use manual container instantiation with SQS.
initially this pull request was on this pull request.
It is a new pull request for issue #670
💡 Motivation and Context
The motivation is to make a better documentation with code samples.
💚 How did you test it?
📝 Checklist
🔮 Next steps