Improve reference guide instructions for BOM usage for Gradle #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neiljbrown
requested review from
maciejwalkowiak,
MatejNedic and
tomazfernandes
as code owners
github-actions
bot
added
the
type: documentation
maciejwalkowiak
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
@neiljbrown big thanks for a PR! If you notice anything else in the reference docs that needs polishing your PRs are very welcome!
|
Hi @maciejwalkowiak - thanks for approving. Yes, I hope to help out more in the future, in whatever way. You and the team (Matej and previously Eddú) have done a great job since taking the reins of the project a while back, and stabilising it. And I’ve seen how much work you guys have continued to put into 3.0, including the great recent SQS contribution from Tomaz. Looks like you’re now close to achieving that goal. Keep up the great work. Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This is an update to the reference guide section 2. Getting Started > 2.1. Bill of Materials
💡 Motivation and Context
Provides improved instructions for how Gradle users can use the Spring Cloud AWS BOM (to manage the versions of the framework's dependencies).
💚 How did you test it?
Checked a rendered preview of the updated AsciiDoc markup in my IDE.
I've also tested the Gradle snippet in my own project.
📝 Checklist
🔮 Next steps
Ready for review and merge.