Auto-Reload for SecretsManager & ParameterStore property sources
#536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwalkowiak
requested review from
MatejNedic and
tomazfernandes
as code owners
github-actions
bot
added
component: core
github-actions
bot
added
the
component: parameter-store
maciejwalkowiak
changed the title
SecretsManager property sourceSecretsManager & ParameterStore property sources
maciejwalkowiak
commented
Oct 14, 2022
| @NestedConfigurationProperty | ||
| private ReloadProperties reload = new ReloadProperties(); | ||
|
|
||
| private boolean monitored; |
There was a problem hiding this comment.
Perhaps this should be moved to ReloadProperties.
github-actions
bot
added
the
type: documentation
|
@MatejNedic docs are pending but other than that ready for review. Depending on how goes with spring-cloud/spring-cloud-commons#1156 maybe there will be a space for improvements in the future. |
|
@MatejNedic reference docs added. |
|
Fixes #377 |
MatejNedic
reviewed
Oct 18, 2022
| @@ -234,7 +324,8 @@ private static void putParameter(LocalStackContainer localstack, String paramete | |||
| } | |||
| } | |||
|
|
|||
| @SpringBootApplication | |||
| @SpringBootConfiguration | |||
There was a problem hiding this comment.
What is the reason for removing SpringBootApplication and replacing it with these 2 annotations?
There was a problem hiding this comment.
To disable component scanning as it was picking up configuration classes declared in the same package in other tests.
...d-aws-secrets-manager-sample/src/main/java/io/awspring/cloud/samples/secretsmanager/App.java
Outdated
Show resolved
Hide resolved
...loud/autoconfigure/config/parameterstore/ParameterStoreConfigDataLoaderIntegrationTests.java
Outdated
Show resolved
Hide resolved
...wspring/cloud/autoconfigure/config/secretsmanager/SecretsManagerReloadAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...wspring/cloud/autoconfigure/config/parameterstore/ParameterStoreReloadAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...wspring/cloud/autoconfigure/config/secretsmanager/SecretsManagerReloadAutoConfiguration.java
Outdated
Show resolved
Hide resolved
| @AutoConfigureAfter({ InfoEndpointAutoConfiguration.class, RefreshEndpointAutoConfiguration.class, | ||
| RefreshAutoConfiguration.class }) | ||
| @ConditionalOnProperty(value = ParameterStoreProperties.CONFIG_PREFIX + ".reload.strategy") | ||
| public class ParameterStoreReloadAutoConfiguration { |
There was a problem hiding this comment.
@ConditionalOnBean(ContextRefresher.class)
|
@MatejNedic thanks for a review. Changes applied. |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-reloading
SecretsManager&ParameterStoreproperty source inspired by Spring Cloud Kubernetes implementation.Turned off by default.
TODO: tests for autoconfigurations, update samples & reference docs.