Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scm section to spring-cloud-aws-dependencies module #310

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Added scm section to spring-cloud-aws-dependencies module #310

merged 1 commit into from
Apr 12, 2022

Conversation

zeldigas
Copy link
Contributor

To help locate changelog for renovate/dependabot

Fixes #308

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

See #308

💚 How did you test it?

Have not tested becuase I'd have to publish it somewhere, but I know that tools such as renovate uses scm details from pom.xml to put a link to repo in opened PR + extract changelog from github if package or CHANGELOG.md is present.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@maciejwalkowiak
Copy link
Contributor

Thanks! I am not sure how to test it either, but it does not hurt for sure.

@maciejwalkowiak maciejwalkowiak added this to the 3.0.0 M1 milestone Apr 12, 2022
@maciejwalkowiak maciejwalkowiak merged commit 7766405 into awspring:main Apr 12, 2022
@zeldigas
Copy link
Contributor Author

zeldigas commented Apr 12, 2022

@maciejwalkowiak I'll provide follow up on next release of spring-cloud-aws and let you know if it fixed the problem or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade Dependency version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify urls in maven pom.xml to point to proper github project
2 participants