Fix method name in S3 AsciiDoc #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is most definitely a typo, the correct method is `S3Template#createSignedGetURL`.
manakbisht
requested review from
maciejwalkowiak,
MatejNedic and
tomazfernandes
as code owners
github-actions
bot
added
the
type: documentation
MatejNedic
approved these changes
Jun 17, 2024
maciejwalkowiak
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is most definitely a typo, the correct method is
S3Template#createSignedGetURL.📢 Type of change
📜 Description
The current AsciiDoc refers to a non-existent method
S3Template#createSignedGetUrl.💡 Motivation and Context
Corrects documentation.
💚 How did you test it?
No code changes.
📝 Checklist
🔮 Next steps