Add enabled flag to Secrets Manager integration.
#1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwalkowiak
requested review from
MatejNedic and
tomazfernandes
as code owners
github-actions
bot
added
component: s3
maciejwalkowiak
changed the title
enabled flag to Secrets Manager integration.
github-actions
bot
added
the
type: documentation
|
@MatejNedic @tomazfernandes up for a review. Same approach will be used for Parameter Store |
|
MatejNedic
approved these changes
Jan 7, 2024
| return new ConfigData(Collections.singletonList(propertySource)); | ||
| // resource is disabled if secrets manager integration is disabled via | ||
| // spring.cloud.aws.secretsmanager.enabled=false | ||
| if (resource.isEnabled()) { |
There was a problem hiding this comment.
I would extract everything under if block in new method.
There was a problem hiding this comment.
I am not a fan of private methods. Not critical, merging as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1005