Fix bug allowing validation to be skipped #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where any `SourceException`s rasied after the model assembler began validation would result in validation getting skipped. This was due to the fact that the assembler calls `onEnd` in its visitor before validation AND whenever it catches that class of exception. `onEnd` will cache its result, so you can't simply call `onError` and guarantee it will be in the output.
mtdowling
approved these changes
May 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This fixes a bug where any
SourceExceptions rasied after the model assembler began validation would result in validation getting skipped. This was due to the fact that the assembler callsonEndin its visitor before validation AND whenever it catches that class of exception.onEndwill cache its result, so you can't simply callonErrorand guarantee it will be in the output.This also updates a few tests that were accidentally doing this, as well as the documentation for the
suppresstrait which incorrectly called itsuppression.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.