Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uncontrolled nondeterminism test iterating over a HashSet #97

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

sarsko
Copy link
Contributor

@sarsko sarsko commented Mar 28, 2023

PR adds a simple test which tests that the uncontrolled nondeterminism checker is able to detect changes in iteration order (as long as the changed iteration order leads to differences which can be seen in the schedule).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@jamesbornholt jamesbornholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

@@ -209,3 +209,21 @@ fn panic_is_yielding() {
scheduler,
);
}

fn iterate_over_hash_set(num_threads: u64) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not really a num_threads, right? num_entries?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants