Implement abort for JoinHandle #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our code we actually call `abort` method on tokio's `JoinHandle` struct, once I tried to use shuttle, I saw that calling `abort` causes another panic ```bash ... thread 'main' panicked at 'not implemented', /Users/koshelev/.cargo/registry/src/github.51.al-1ecc6299db9ec823/shuttle-0.4.1/src/future/mod.rs:42:9 stack backtrace: ``` Not sure if this is the right way to implement it, happy to iterate on that as well as adding more tests if required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our code we actually call
abortmethod on tokio'sJoinHandlestruct, once I tried to use shuttle, I saw that callingabortcauses another panicNot sure if this is the right way to implement it, happy to iterate on that as well as adding more tests if required. I am not confident that
parkused inside the unit test does what I expect (park task , my flaky finder hasn't discovered any issues with it though:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.