Allow spawning of an arbitrary number of tasks. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we required users to specify (via the `max_tasks` parameter in the `Config`) the maximum number of tasks that could be spawned during an execution. This change lifts that restriction, and allows spawning of an arbitrary number of tasks. Note: The PCT scheduler still only supports creation of upto 16 tasks. A forthcoming PR will update PCT to also support spawning of an arbitrary number of tasks.
jamesbornholt
approved these changes
Apr 8, 2021
|
|
||
| let scheduler = RandomScheduler::new(100); | ||
| #[test] | ||
| fn many_tasks_with_mutex() { |
There was a problem hiding this comment.
Once we fix PCT, we should duplicate this test and run it under PCT as well?
src/runtime/execution.rs
Outdated
Comment on lines
207
to
206
| tasks: Vec::with_capacity(max_tasks), | ||
| tasks: Vec::with_capacity(DEFAULT_INLINE_TASKS), |
There was a problem hiding this comment.
Might be worth changing this field into a SmallVec just for consistency.
jamesbornholt
requested changes
Apr 8, 2021
src/runtime/task/mod.rs
Outdated
Comment on lines
199
to
202
| if tid.0 >= self.tasks.len() { | ||
| self.tasks.resize(2 * self.tasks.len(), false); | ||
| } | ||
| assert!(self.tasks.len() > tid.0); |
There was a problem hiding this comment.
What happens if our current size is 32 and then we ask to insert task 70? I think we should just resize to length tid.0 + 1 and let the BitVec decide how it wants to amortize that cost (it just delegates to Vec IIRC).
Previously, we required users to specify (via the `max_tasks` parameter in the `Config`) the maximum number of tasks that could be spawned during an execution. This change lifts that restriction, and allows spawning of an arbitrary number of tasks. Note: The PCT scheduler still only supports creation of upto 16 tasks. A forthcoming PR will update PCT to also support spawning of an arbitrary number of tasks.
jamesbornholt
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we required users to specify (via the
max_tasksparameter in theConfig) the maximum number of tasks that could be spawned during an execution. This change lifts that restriction, and allows spawning of an arbitrary number of tasks.Note: The PCT scheduler still only supports creation of upto 16 tasks. A forthcoming PR will update PCT to also support spawning of an arbitrary number of tasks.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.