config: add support for lastWill and keep alive #468
+75
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmarOk1412
force-pushed
the
main
branch
2 times, most recently
from
8dff9d9
to
ddcf176
Compare
By default, MQTT keep-alive is 1200 seconds and AWS broker add a
1.5x factor, so it takes generally 15 min to discover that a device
is disconnected (30 min in the worst case)
This patch allow a user to configure a last will and change the
default timeout (30 seconds will be the minimum authorized by AWS)
New config will have for example:
"last-will-topic": "things/myDevice/shadow/name/demo-shadow/update",
"last-will-message": "{\"state\":{\"reported\":{\"connected\":false}}}",
"connect-timeout": 0,
"keep-alive": 30,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, MQTT keep-alive is 1200 seconds and AWS broker add a 1.5x factor, so it takes generally 15 min to discover that a device is disconnected (30 min in the worst case)
This patch allow a user to configure a last will and change the default timeout (30 seconds will be the minimum authorized by AWS)
New config will have for example:
Motivation
[- Please give a brief description for the background of this change.
Modifications
Change summary
This is a WIP I guess, I don't know if this feature is wanted
Revision diff summary
If there is more than one revision, please explain what has been changed since the last revision.
Testing
You may want a rule to republish to the shadow topic, but with this config, instead waiting 30 minutes to get a KEEP_ALIVE disconnection, you can wait 45 seconds.