Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Swift 6 build on Linux #278

Merged
merged 18 commits into from
Sep 10, 2024
Merged

Fix Swift 6 build on Linux #278

merged 18 commits into from
Sep 10, 2024

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Aug 21, 2024

Issue #, if available:
#277 and #185
Description of changes:
This PR fixes a bunch of issues on Swift 6.

  • Openssl Linux Fix: We were always excluding the AWS_C_CAL_OPENSSLCRYPTO_COMMON_H header. I have no idea why it was working before Swift 6.
  • Capturing a pointer in a sendable closure: I have marked it @unchecked Sendable. There are a few more similar issues if I enable complete_concurrency. I will address these in the next PR.
  • Semaphore.wait is deprecated. I replaced it with withCheckedThrowingContinuation.
  • INTEL_NO_ITTNOTIFY_API macro stopped working for an unknown reason when placed in the config file. I have moved it to Package.swift, which seems to work.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@waahm7 waahm7 merged commit ec04c6a into main Sep 10, 2024
25 checks passed
@waahm7 waahm7 deleted the fix-swift6 branch September 10, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants