Add string array as an option for request context params for endpoint resolution #276
Conversation
|
|
||
| /// Note: this function and associated scan function above are copied verbatim from | ||
| /// swift standard lib where its private. | ||
| public func withArrayOfCStrings<R>( |
There was a problem hiding this comment.
These functions should be internal to our module and not public. Also, if performance is not a concern, we should just implement the simpler version from https://oleb.net/blog/2016/10/swift-array-of-c-strings/.
There was a problem hiding this comment.
ugh, i didnt really understand how swift works. updated to a much simpler version.
Source/AwsCommonRuntimeKit/sdkutils/endpoint/EndpointsRequestContext.swift
Outdated
Show resolved
Hide resolved
Source/AwsCommonRuntimeKit/sdkutils/endpoint/EndpointsRequestContext.swift
Outdated
Show resolved
Hide resolved
Source/AwsCommonRuntimeKit/sdkutils/endpoint/EndpointsRequestContext.swift
Show resolved
Hide resolved
|
|
||
| func withByteCursorArrayFromStringArray<R>( | ||
| _ arg: [String], _ body: (UnsafePointer<aws_byte_cursor>, Int) -> R) -> R { | ||
| let cursors = arg.map { aws_byte_cursor_from_c_str($0) } |
There was a problem hiding this comment.
This is not memory-safe. $0 is a Swift string and is only valid for the scope of aws_byte_cursor_from_c_str. The behavior is undefined after this line because the cursor refers to a memory area not guaranteed by the Swift compiler. We will need to make a copy, and then release it using our allocator.
There was a problem hiding this comment.
yeah, you are right. i added the copy back.
is it possible to run asan or some sort of mem checker in swift?
There was a problem hiding this comment.
We do have our tracing allocator hooked up, but I never looked into ASAN. It seems easy enough to enable: https://www.swift.org/documentation/server/guides/llvm-sanitizers.html.
Co-authored-by: Waqar Ahmed Khan <waahm7@gmail.com>
Co-authored-by: Waqar Ahmed Khan <waahm7@gmail.com>
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.