Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generate random callback #147

Merged
merged 11 commits into from
Feb 4, 2023
Merged

Fix generate random callback #147

merged 11 commits into from
Feb 4, 2023

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Jan 23, 2023 •
edited
Loading

Issue #127

Description of changes:

  • Expose generateRandom as a non-C closure after relevant changes in C
  • A new pattern for to retain callbacks until shutdown callback has fired which doesn't require double retain/release.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@waahm7
Revert "Revert main to v0.5.4" (#149)
3c63ad0 
* Revert "Revert main to v0.5.4 (#148)"

This reverts commit 1c0ddda.

* latest submodules
@waahm7 waahm7 changed the base branch from main to stage January 23, 2023 23:31
@waahm7 waahm7 marked this pull request as ready for review January 23, 2023 23:44
Base automatically changed from stage to main February 1, 2023 23:47
@waahm7 waahm7 enabled auto-merge (squash) February 4, 2023 01:54
@waahm7 waahm7 merged commit 33a6583 into main Feb 4, 2023
@waahm7 waahm7 deleted the fix-generate-random branch February 4, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graebm graebm graebm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waahm7 @graebm