Don't declare jsii-runtime as a dependency of any component directly #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this direct dependency that was added to some modules is a transitive dependency of the cdk packages that are used just for testing. The original intent of adding jsii-runtime as a dependency was to just exclude the jackson version that are dependencies of it. The scope of the dependency was missing when it should be <scope>test</scope> which cause the dependency to be included in the final jar of the connectors. Instead I declare it in the top-level dependency management with its exclusions so the dependency scope is unchanged - The test scope tag was also missing on a cdk dependency of the cloudwatch connector
AbdulR3hman
approved these changes
Aug 30, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
- Add athena connector exception class to classify Runtime Exception (#2241) - build(deps): bump software.amazon.awssdk:bom from 2.27.17 to 2.27.21 (#2249) - build(deps): bump software.amazon.awssdk:bom from 2.27.17 to 2.27.21 - build(deps-dev): bump log4j2Version from 2.23.1 to 2.24.0 (#2247) - build(deps-dev): bump log4j2Version from 2.23.1 to 2.24.0 - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client from 8.15.0 to 8.15.1 (#2246) - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client - build(deps): bump aws-sdk.version from 1.12.770 to 1.12.771 (#2245) - build(deps): bump aws-sdk.version from 1.12.770 to 1.12.771 - Updated Postgresql Split Query Comment (#2242) - Collate Aware Postgresql String Builder (#2216) - build(deps): bump org.yaml:snakeyaml from 2.2 to 2.3 (#2236) - build(deps): bump org.yaml:snakeyaml from 2.2 to 2.3 - build(deps): bump surefire.failsafe.version from 3.4.0 to 3.5.0 (#2233) - build(deps): bump surefire.failsafe.version from 3.4.0 to 3.5.0 - build(deps): bump net.snowflake:snowflake-jdbc from 3.18.0 to 3.19.0 (#2235) - build(deps): bump net.snowflake:snowflake-jdbc from 3.18.0 to 3.19.0 - build(deps): bump org.apache.maven.plugins:maven-javadoc-plugin from 3.8.0 to 3.10.0 (#2234) - build(deps): bump org.apache.maven.plugins:maven-javadoc-plugin - build(deps): bump com.microsoft.azure:msal4j from 1.17.0 to 1.17.1 (#2231) - build(deps): bump com.microsoft.azure:msal4j from 1.17.0 to 1.17.1 - build(deps): bump org.apache.commons:commons-lang3 from 3.16.0 to 3.17.0 (#2237) - build(deps): bump org.apache.commons:commons-lang3 from 3.16.0 to 3.17.0 - build(deps): bump com.clickhouse:clickhouse-jdbc from 0.6.4 to 0.6.5 (#2232) - build(deps): bump com.clickhouse:clickhouse-jdbc from 0.6.4 to 0.6.5 - build(deps): bump software.amazon.jsii:jsii-runtime from 1.102.0 to 1.103.1 (#2229) - build(deps): bump software.amazon.jsii:jsii-runtime - build(deps): bump software.amazon.awssdk:bom from 2.27.12 to 2.27.17 (#2230) - build(deps): bump software.amazon.awssdk:bom from 2.27.12 to 2.27.17 - Don't declare jsii-runtime as a dependency of any component directly (#2228) - build(deps): bump software.amazon.awssdk:bom from 2.27.10 to 2.27.12 (#2214) - build(deps): bump software.amazon.awssdk:bom from 2.27.10 to 2.27.12 - build(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 3.16.1 to 3.16.2 (#2213) - build(deps-dev): bump nl.jqno.equalsverifier:equalsverifier - build(deps): bump com.microsoft.sqlserver:mssql-jdbc from 12.8.0.jre11 to 12.8.1.jre11 (#2212) - build(deps): bump com.microsoft.sqlserver:mssql-jdbc - build(deps): bump com.microsoft.azure:msal4j from 1.16.2 to 1.17.0 (#2210) - build(deps): bump com.microsoft.azure:msal4j from 1.16.2 to 1.17.0 - build(deps): bump org.apache.maven.plugins:maven-checkstyle-plugin from 3.4.0 to 3.5.0 (#2211) - build(deps): bump org.apache.maven.plugins:maven-checkstyle-plugin - build(deps): bump org.postgresql:postgresql from 42.7.3 to 42.7.4 (#2209) - build(deps): bump org.postgresql:postgresql from 42.7.3 to 42.7.4 - Revert "build(deps): bump software.amazon.msk:aws-msk-iam-auth from 2.1.1 to 2.2.0" (#2181) - build(deps): bump com.google.cloud:google-cloud-storage from 2.41.0 to 2.42.0 (#2189) - build(deps): bump com.google.cloud:google-cloud-storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Don't declare jsii-runtime as a dependency of any component directly
this direct dependency that was added to some modules is a transitive
dependency of the cdk packages that are used just for testing.
The original intent of adding jsii-runtime as a dependency was to just
exclude the jackson version that are dependencies of it.
The scope of the dependency was missing when it should be
test which cause the dependency to be included in the
final jar of the connectors.
Instead I declare it in the top-level dependency management with its
exclusions so the dependency scope is unchanged
The test scope tag was also missing on a cdk dependency of the cloudwatch connector