Make KPL consumers more testable #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffAtDeere
force-pushed
the
make_testable
branch
from
b81fb72
to
79d4b43
Compare
Introduced UserRecord object and KinesisProducer.addUserRecord(UserRecord) method.
JeffAtDeere
force-pushed
the
make_testable
branch
from
79d4b43
to
bedd83d
Compare
|
Is the testing goal for increase unit testing in the KPL, or for your own unit testing? My feeling is that if it's for the KPL the private constructors should be package private. If it's for your own testing public makes more sense. |
|
Excellent question. This is for testing of my things that use KPL. The private constructors mean I can't make instances nor can I mock over them. |
|
Similar reasoning for the interface on |
|
@pfifer does that make sense? If so, can you merge this or let me know if any changes are required? Thank you. |
|
Yes it makes sense. I'm currently in the process of planning, and preparing a release. I will have an update hopefully later this week. |
|
Please confirm that we can use, modify, copy, and redistribute this contribution. Thanks. |
|
I checked and can confirm. |
pfifer
added a commit
to pfifer/amazon-kinesis-producer
that referenced
this pull request
Nov 14, 2017
* Added Windows support The 0.12.x version now supports Windows. The Windows version is currently mastered on the branch `windows`, which will be merged at a later date. The build instructions for Windows are currently out of date, and will be updated at a later date.__ * Issue awslabs#113 * Issue awslabs#74 * Issue awslabs#73 * Removed the libc wrapper The libc wrapper lowered the required version of glibc. The KPL is now built with an older version of libc, which removes the need for the wrapper. * PR awslabs#139 * Set the minimum required version of macOS to 10.9. The KPL is now built against macOS 10.9. * Issue awslabs#117 * PR awslabs#138 * Allow exceptions to bubble to the thread exception handler for Daemon threads. Exceptions that occur on daemon threads will now be allowed to propagate to the thread exception handler. This doesn't provide any additional monitoring or handling of thread death. * PR awslabs#112 * Issue awslabs#111 * Updated `amazon-kinesis-producer-sample` to use the correct properties in its configuration file. * PR awslabs#120 * Issue awslabs#119 * Updated documentation of `AggregationMaxSize` to match actual Kinesis limits. * PR awslabs#133 * Added support for setting `ThreadingModel`, and `ThreadPoolSize` using a properties file. * PR awslabs#134 * Issue awslabs#124 * Extracted `IKinesisProducer` from `KinesisProducer` to allow for easier testing. * PR awslabs#136
pfifer
added a commit
that referenced
this pull request
Nov 14, 2017
* Added Windows support The 0.12.x version now supports Windows. The Windows version is currently mastered on the branch `windows`, which will be merged at a later date. The build instructions for Windows are currently out of date, and will be updated at a later date.__ * Issue #113 * Issue #74 * Issue #73 * Removed the libc wrapper The libc wrapper lowered the required version of glibc. The KPL is now built with an older version of libc, which removes the need for the wrapper. * PR #139 * Set the minimum required version of macOS to 10.9. The KPL is now built against macOS 10.9. * Issue #117 * PR #138 * Allow exceptions to bubble to the thread exception handler for Daemon threads. Exceptions that occur on daemon threads will now be allowed to propagate to the thread exception handler. This doesn't provide any additional monitoring or handling of thread death. * PR #112 * Issue #111 * Updated `amazon-kinesis-producer-sample` to use the correct properties in its configuration file. * PR #120 * Issue #119 * Updated documentation of `AggregationMaxSize` to match actual Kinesis limits. * PR #133 * Added support for setting `ThreadingModel`, and `ThreadPoolSize` using a properties file. * PR #134 * Issue #124 * Extracted `IKinesisProducer` from `KinesisProducer` to allow for easier testing. * PR #136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced interface on KinesisProducer for testability/mockability.
Introduced UserRecord object and KinesisProducer.addUserRecord(UserRecord) method.
@pfifer
This commit was done with 100% backwards compatibility in mind.