Wrap process.waitFor() in a try-finally that calls shutdown on proces…

…s output reader threads (#94) Fix for #93
awslabs · May 5, 2017 · 7f775d5 · 7f775d5
1 parent 23d4dfd
commit 7f775d5
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/...amazon-kinesis-producer/src/main/java/com/amazonaws/services/kinesis/producer/Daemon.java b/...amazon-kinesis-producer/src/main/java/com/amazonaws/services/kinesis/producer/Daemon.java
@@ -467,12 +467,14 @@ public void apply(Logger logger, String message) {
 
         executor.submit(stdOutReader);
         executor.submit(stdErrReader);
-        int code = process.waitFor();
-
-        stdOutReader.shutdown();
-        stdErrReader.shutdown();
-        deletePipes();
-        fatalError("Child process exited with code " + code, code != 1);
+        try {
+            int code = process.waitFor();
+            fatalError("Child process exited with code " + code, code != 1);
+        } finally {
+            stdOutReader.shutdown();
+            stdErrReader.shutdown();
+            deletePipes();
+        }
     }
 
     private void updateCredentials() throws InterruptedException {