Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shard end v2 #624

Merged
merged 10 commits into from
Oct 23, 2019
Merged

Shard end v2 #624

merged 10 commits into from
Oct 23, 2019

Conversation

ychunxue
Copy link
Contributor

Description of changes:

Change is made in ShutdownTask. When reaching a ShutdownTask with Shard_End shutdown reason, do a re-validation about if the current shard reached shard_end. If it didn't reach the shard_end, force the current ShardConsumer to lose the lease and shutdown with Lease_Lost state. This would enable other workers to pick up the lease for the unclosed shard.

Test did for the changes:

Unit tests covered ShardConsumer shutdown in three different scenarios: Lease lost, ShardEnd and incorrect ShardEnd.

Functional test done in real ShardEnd and incorrect ShardEnd scenarios.

Long running regression test is done with Split and Merge accounts. And also having the incorrect ShardEnd triggered randomly during the test to catch regressions.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Cory-Bradshaw Cory-Bradshaw merged commit 1f68648 into awslabs:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants