Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for KCL Python Release 2.1.0 #201

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Conversation

zengyu714
Copy link
Contributor

Issue #, if available:

Description of changes:

Testing

  • Local testing
# producer
python sample_kinesis_wordputter.py -r us-west-2 --stream kclpysample -w cat -w dog -w bird -w lobster -p 5
# consumer
`python amazon_kclpy_helper.py --print_command \
--java /Library/Java/JavaVirtualMachines/amazon-corretto-8.jdk/Contents/Home/bin/java \
--properties sample.properties`
  • pytest
 11 passed, 2 warnings in 0.17s

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shanmsac
Copy link

One of the unit test checks is failing, can you check that? changes look good.

@zengyu714
Copy link
Contributor Author

One of the unit test checks is failing, can you check that? changes look good.

Looks like GitHub workflow no longer supports Python3.6 on x64 architecture, oh here's the open issue (actions/setup-python#544) regarding this error

Run actions/setup-python@v2
Version 3.6 was not found in the local cache
Error: Version 3.6 with arch x64 not found
The list of all available versions can be found here: https://github.com/actions/python-versions/main/versions-manifest.json

@shanmsac
Copy link

lgtm

@shanmsac shanmsac closed this Jan 13, 2023
@shanmsac shanmsac reopened this Jan 13, 2023
Copy link

@shanmsac shanmsac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zengyu714 zengyu714 merged commit 4c912f5 into awslabs:master Jan 13, 2023
@zengyu714 zengyu714 deleted the pub-v2.1.0 branch January 13, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants