Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nodeadm): remove aws sdk v1 refs #1887

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

ndbaker1
Copy link
Member

@ndbaker1 ndbaker1 commented Jul 16, 2024

Issue #, if available:

Description of changes:

  • remove imports to aws-sdk-go v1 pkg. (deletes more vendored packages 😉)
  • fix misc. test package name

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done

See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.

@ndbaker1 ndbaker1 marked this pull request as ready for review July 16, 2024 23:29
Copy link
Member

@Issacwww Issacwww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this clean up! 🚀

@ndbaker1 ndbaker1 merged commit 8755e2e into awslabs:main Jul 16, 2024
10 checks passed
@ndbaker1 ndbaker1 deleted the no-sdk-v1 branch July 16, 2024 23:46
mebays pushed a commit to mebays/amazon-eks-ami that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants