Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix versions script #1492

Closed
wants to merge 2 commits into from
Closed

Conversation

bwagner5
Copy link
Contributor

Issue #, if available:
n/a

Description of changes:

  • Fix versions file for cached images

Was showing like this:

  "images": [
    "602401143452.dkr.ecr.ap-south-2",
    "602401143452.dkr.ecr-fips.ap-south-2",
    "602401143452.dkr.ecr.us-west-2.amazonaws.com",
    "af-south-1",
    "ap-east-1",
    "ap-northeast-1",
    "ap-northeast-2",
    "ap-northeast-3",
    "ap-south-1",
    "ap-southeast-1",
    "ap-southeast-2",
    "ap-southeast-3",
    "ap-southeast-4",
    "ca-central-1",
    "eu-central-1",
    "eu-central-2",
    "eu-north-1",
    "eu-south-1",
    "eu-south-2",
    "eu-west-1",
    "eu-west-2",
    "eu-west-3",
    "il-central-1",
    "me-central-1",
    "me-south-1",
    "sa-east-1",
    "us-east-1",
    "us-east-2.amazonaws.com",
    "us-west-1",
    "us-west-2"
  ]

now shows like this:

  "images": [
    "amazon-k8s-cni-init:v1.14.1",
    "amazon-k8s-cni-init:v1.14.1-eksbuild.1",
    "amazon-k8s-cni-init:v1.15.0-eksbuild.2",
    "amazon-k8s-cni:v1.14.1",
    "amazon-k8s-cni:v1.14.1-eksbuild.1",
    "amazon-k8s-cni:v1.15.0-eksbuild.2",
    "kube-proxy:v1.28.1-minimal",
    "kube-proxy:v1.28.1-minimal-eksbuild.1",
    "kube-proxy:v1.28.2-minimal-eksbuild.2",
    "pause:3.5"
  ]

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done

See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.

@cartermckinnon
Copy link
Member

So we can confirm things look as expected: #1493

@cartermckinnon
Copy link
Member

/ci build
+build cache_container_images=true

@github-actions
Copy link
Contributor

@cartermckinnon roger that! I've dispatched a workflow. 👍

@github-actions
Copy link
Contributor

@cartermckinnon the workflow that you requested has completed. 🎉

Kubernetes versionBuildLaunchTest
1.23success ✅skipped ⏭️skipped ⏭️
1.24success ✅skipped ⏭️skipped ⏭️
1.25success ✅skipped ⏭️skipped ⏭️
1.26success ✅skipped ⏭️skipped ⏭️
1.27success ✅skipped ⏭️skipped ⏭️
1.28success ✅skipped ⏭️skipped ⏭️

@cartermckinnon
Copy link
Member

version info from CI looks fine to me (1.28):

"images":
    [
        "amazon-k8s-cni-init:v1.14.1",
        "amazon-k8s-cni-init:v1.14.1-eksbuild.1",
        "amazon-k8s-cni-init:v1.15.1",
        "amazon-k8s-cni-init:v1.15.1-eksbuild.1",
        "amazon-k8s-cni:v1.14.1",
        "amazon-k8s-cni:v1.14.1-eksbuild.1",
        "amazon-k8s-cni:v1.15.1",
        "amazon-k8s-cni:v1.15.1-eksbuild.1",
        "kube-proxy:v1.28.1-minimal",
        "kube-proxy:v1.28.1-minimal-eksbuild.1",
        "kube-proxy:v1.28.2-minimal-eksbuild.2",
        "pause:3.5"
    ]

@bwagner5 did something change in ctr's output format? wondering what broke this

@bwagner5
Copy link
Contributor Author

I'm not sure what broke this... I just noticed it when pulling version info from the latest AMI.

@cartermckinnon
Copy link
Member

@bwagner5 I don't see this issue with HEAD, I'm wondering if your checkout just needed this fix: #1461 ?

@bwagner5
Copy link
Contributor Author

bwagner5 commented Nov 3, 2023

@bwagner5 I don't see this issue with HEAD, I'm wondering if your checkout just needed this fix: #1461 ?

could be, if you're not seeing in HEAD I'll just close.

@bwagner5 bwagner5 closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants