Better Final log lines #1225
Closed
Better Final log lines #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in ec2 instances without a GPU, currently the final log line of the bootstrap.sh script it: `nvidia-smi not found` Upon troubleshooting a node that had a bootstrap issue, that logline appears as a probable cause, 'not found' is clearly an issue at first glance.. I'm suggesting refactoring the logline, to explicitly specify that it is a warning, and when it can be ignored, as well as adding a final logline to indicate execution end of the script.
|
@cartermckinnon Your PR looks awesome, For some reason my description is missing, altough I did write one, edit: typos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.