fix(ci): partially revert checking out head from current clone. #4693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
none
Description of changes:
To check against ^HEAD, we were cloning from the existing filesystem's clone. This breaks under certain internal build scenarios where our .git folder is in a different place. Go back to cloning from GitHub for non Nix use, but leave the current behavior inside a Nix shell.
Call-outs:
Cloning inside a nix devshell is throwing an error, appears to be related to NixOS/nixpkgs#299949 .
ad-hoc test run of the cross_compat test with these changes
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? CI, ad-hoc
Is this a refactor change? no
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.