feat(s2n-quic-events): add search_completed boolean to mtu updated event #2322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change adds a
search_completed
boolean field to themtu_updated
event, to indicate when MTU probing has completedCall-outs:
At the time the MTU is changed (after a probe is acked for example), we often don't know if that MTU value is going to be the final MTU, so the search_completed flag will be false. It some cases, the MTU may not change again, but we this PR will emit an additional
mtu_updated
event in these cases to update thesearch_completed
flag.Testing:
Added tests and integration tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.