build: fix clippy warnings for 1.78 #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ippy # Conflicts: # quic/s2n-quic-core/src/buffer/reassembler/slot.rs
jmayclin
reviewed
May 4, 2024
| @@ -84,10 +83,6 @@ impl<'a, Config: endpoint::Config> super::Payload for Payload<'a, Config> { | |||
| Payload::PathValidationOnly(inner) => inner.on_transmit(context), | |||
| } | |||
| } | |||
|
|
|||
| fn packet_number_space(&self) -> PacketNumberSpace { | |||
There was a problem hiding this comment.
apparently, I'm not sure why it just started popping up in clippy though
There was a problem hiding this comment.
The trait is internal to the crate and clippy just started being able to detect this type of dead code. But yeah this method just was never called anywhere.
camshaft
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
A new version of rustc dropped with new clippy checks. This PR fixes those.
Call-outs:
The one in
batch.rsseems like a false positive, based on rust-lang/rust-clippy#12756Testing:
CI
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed? -->
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.