Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 1.30.0 #2859

Merged
merged 32 commits into from
May 27, 2021
Merged

chore(release): 1.30.0 #2859

merged 32 commits into from
May 27, 2021

Conversation

aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented May 27, 2021

See CHANGELOG

RomainMuller and others added 30 commits April 22, 2021 12:00
The SerVer prerelease identifier uses a `-` prefix, not `.`.
Adds @corymhall as a contributor for bug.

This was requested by RomainMuller [in this comment](#2793 (comment))
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: 👨🏻‍💻 Romain Marcadier <rmuller@amazon.com>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: 👨🏻‍💻 Romain Marcadier <rmuller@amazon.com>
The current behavior of rosetta (extract) is to use a number of node worker
threads equal to half the number of CPU cores. On large CI/CD build hardware,
this may mean creating a huge number of worker threads which causes more
contention than benefit.

Introduce `JSII_ROSETTA_MAX_WORKER_COUNT` to limit the maximum number of workers
(defaults to `16`).

See aws/aws-cdk#14389 for more motivation from the AWS CDK.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.
This makes it clearer which functions are intended for direct customer
use versus those that are meant to be used only by the generated code.

The older locations remain, but were marked as `Deprecated:`, they
will be removed in a subsequent release (before GA).

Fixes #2721



---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
chore: npm-check-updates && yarn upgrade
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.
This PR adds relevant links from the TypeScript Handbook to the [jsii type system page]

[jsii type system page]: https://aws.github.io/jsii/specification/2-type-system/

---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
Also remove Shiv, as he's no longer in the CDK team.
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 2.3.4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v2.3.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
By default, all Github actions have read permissions via the standard
`GITHUB_TOKEN`. For jobs that require write permission, explicitly
add the necessary permissions.

In the case of the 'Yarn Upgrade' Github action, separated the
'upgrade' step and the 'pull request' step into separate
jobs to build a better security boundary between the two.

Inspired from: https://github.com/projen/projen/blob/a4f875d07b57f8f8247b9352e34c3c83759afe82/.github/workflows/upgrade-dependencies.yml
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.
We have started using `jsii-reflect` and `codemaker` in the [construct-hub-webapp](https://github.com/cdklabs/construct-hub-webapp) to generate API references on the client side.

These are the modifications needed in order for the modules to load in a browser environment. 

---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
…ed (#2851)

When importing a module in Python, you can get this error:
```
NameError: name 'List' is not defined
```

JSII generated code:
```python
import abc
import builtins
import datetime
import enum
import typing

import jsii
import publication
import typing_extensions

from ._jsii import *

__all__: List[typing.Any] = []  # <--- HERE IS THE BUG

publication.publish()
```

Just need to prefix `List` with `typing.`

Related issue/pr:

- #2750
- #2757

---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0

Fixes  aws/aws-cdk#13474

---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: 👨🏻‍💻 Romain Marcadier <rmuller@amazon.com>
RomainMuller and others added 2 commits May 27, 2021 09:26
Quoting the package path in the sub-shell command so that spaces are not
incorrectly interpreted as argument delimiters.

Fixes #2748
@aws-cdk-automation aws-cdk-automation added the pr/no-squash This PR should be merged instead of squash-merging it label May 27, 2021
@mergify
Copy link
Contributor

mergify bot commented May 27, 2021

The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged.
[Conventional Commits]: https://www.conventionalcommits.org

@mergify
Copy link
Contributor

mergify bot commented May 27, 2021

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label May 27, 2021
@mergify
Copy link
Contributor

mergify bot commented May 27, 2021

Merging (no-squash)...

@RomainMuller RomainMuller merged commit adae23f into release May 27, 2021
@RomainMuller RomainMuller deleted the bump/1.30.0 branch May 27, 2021 14:53
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-squash This PR should be merged instead of squash-merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.