Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vitest to proxy server #555

Merged
merged 11 commits into from
Aug 26, 2024
Merged

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Aug 23, 2024

Description

Adds Vitest to the proxy server and updated some of the TypeScript setup, as well as a few dependency updates.

These are infrastructure tasks that are paving the way for the default connection logic coming in a future PR.

  • Update TypeScript, ESLint, Prettier, Vitest to latest
    • Required fixing a few new warnings from Prettier and ESLint
  • Add Vitest to proxy server
    • Add simple test of paths
    • Add coverage step for CI
  • Move check:types script to each package
  • Move proxy server source code files in to ./src/ directory
    • Updated relative path definitions and moved to a separate file for easier mocking
  • Update root package.json
    • Add private: true to prevent accidental publishing
    • Add workspaces for slightly better monorepo functionality
    • Add pnpm to the engines section matching other popular monorepo setups

Validation

  • Smoke test production build
  • Smoke test development build
  • Run typical checks and tests

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review August 23, 2024 16:28
@kmcginnes kmcginnes marked this pull request as draft August 23, 2024 16:30
@kmcginnes kmcginnes marked this pull request as ready for review August 23, 2024 17:11
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 10 lines in your changes missing coverage. Please review.

Project coverage is 15.23%. Comparing base (a86b9b9) to head (f4016e2).
Report is 2 commits behind head on main.

Files Patch % Lines
...ges/graph-explorer-proxy-server/src/node-server.ts 0.00% 7 Missing ⚠️
...components/Select/internalComponents/SelectBox.tsx 0.00% 2 Missing ⚠️
...-explorer/src/components/utils/canvas/drawImage.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
+ Coverage   14.84%   15.23%   +0.39%     
==========================================
  Files         404      431      +27     
  Lines       20296    21483    +1187     
  Branches      997     1076      +79     
==========================================
+ Hits         3013     3273     +260     
- Misses      17006    17926     +920     
- Partials      277      284       +7     
Flag Coverage Δ
unittests 15.23% <44.44%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmcginnes
Copy link
Collaborator Author

We are ignoring that coverage report. The proxy server code had 0 tests until this PR. This is the first time we are running code coverage on it. The numbers are expected to be low.

@kmcginnes kmcginnes merged commit 4176073 into aws:main Aug 26, 2024
3 checks passed
@kmcginnes kmcginnes deleted the proxy-server-vitest branch August 26, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants