Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ESLint v9 flat config files #490

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Use ESLint v9 flat config files #490

merged 4 commits into from
Jul 16, 2024

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Jul 13, 2024

Description

  • Upgrade ESLint to version 9
  • Upgrade ESLint plugins
  • Rebuild ESLing config file in flat file format (required by v9)
  • Turn off some TypeScript rules we aren't quite ready to fix
  • Fix common sense issues

Validation

  • Run pnpm check:lint
  • Smoke test app

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

Copy link

codecov bot commented Jul 14, 2024

Codecov Report

Attention: Patch coverage is 44.73684% with 21 lines in your changes missing coverage. Please review.

Project coverage is 14.99%. Comparing base (361c4ba) to head (78fe703).
Report is 58 commits behind head on main.

Files Patch % Lines
...mponents/Graph/hooks/useManageElementsSelection.ts 0.00% 3 Missing ⚠️
...graph-explorer/src/components/Graph/Graph.model.ts 0.00% 2 Missing ⚠️
...orer/src/components/Graph/hooks/useRenderBadges.ts 0.00% 2 Missing ⚠️
packages/graph-explorer/src/hooks/useFetchNode.ts 0.00% 2 Missing ⚠️
...duleContainer/components/ModuleContainerHeader.tsx 0.00% 1 Missing ⚠️
...Tabular/controls/ExportControl/transfomerToJson.ts 0.00% 1 Missing ⚠️
.../components/Tabular/filters/SingleSelectFilter.tsx 0.00% 1 Missing ⚠️
...aph-explorer/src/connector/fetchDatabaseRequest.ts 0.00% 1 Missing ⚠️
...ges/graph-explorer/src/core/ThemeProvider/types.ts 0.00% 1 Missing ⚠️
...ules/AvailableConnections/AvailableConnections.tsx 0.00% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
+ Coverage   13.97%   14.99%   +1.01%     
==========================================
  Files         414      420       +6     
  Lines       30639    30448     -191     
  Branches      878      960      +82     
==========================================
+ Hits         4283     4566     +283     
+ Misses      26026    25550     -476     
- Partials      330      332       +2     
Flag Coverage Δ
unittests 14.99% <44.73%> (+1.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmcginnes kmcginnes marked this pull request as ready for review July 16, 2024 20:58
Copy link
Member

@michaelnchin michaelnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kmcginnes !

@kmcginnes kmcginnes merged commit b689f93 into aws:main Jul 16, 2024
1 check passed
@kmcginnes kmcginnes deleted the eslint-9 branch July 16, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Update to ESLint v9
2 participants