Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes #427

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Minor changes #427

merged 7 commits into from
Jun 5, 2024

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Jun 5, 2024

Description

This is a collection of minor changes that I made along the way to deferred neighbor counts.

  • Add a test for one of the common keyword search template cases
  • Make "no results" toast message consistent across expand neighbor requests
  • Consolidate mutltiple useEntities() hook call in GraphViewer
  • Fix VSCode Jest debugging
  • Fix edge case where node badges can be stale if the canvas hasn't been resized

Validation

  • Run tests
  • Sanity check UI

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes requested a review from vkagamlyk June 5, 2024 14:38
@kmcginnes kmcginnes marked this pull request as ready for review June 5, 2024 14:39
@kmcginnes kmcginnes merged commit 67105e3 into aws:main Jun 5, 2024
1 check passed
@kmcginnes kmcginnes deleted the minor-changes branch June 5, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants