Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection reset error message #288

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Mar 29, 2024

Description

Adds a new display error for ECONNRESET code.

Validation

I saw this error when trying to connect to a Neptune server that must be down. Other Neptune servers were working fine.

Related Issues

Related to issue #275

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I have run pnpm run checks to ensure code compiles and meets standards.
  • I have run pnpm run test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

Copy link
Contributor

@vkagamlyk vkagamlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.17%. Comparing base (2744e93) to head (40fc1de).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
+ Coverage   12.15%   12.17%   +0.01%     
==========================================
  Files         411      411              
  Lines       30575    30581       +6     
  Branches      776      777       +1     
==========================================
+ Hits         3717     3723       +6     
  Misses      26525    26525              
  Partials      333      333              
Flag Coverage Δ
unittests 12.17% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@michaelnchin michaelnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kmcginnes !

@vkagamlyk vkagamlyk merged commit 2031129 into aws:main Apr 2, 2024
3 checks passed
@kmcginnes kmcginnes deleted the connection-reset-error branch April 2, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants