Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search bottom bar UI #260

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Mar 8, 2024

Issue #, if available: #261

Description of changes:

  • Arrange layout using flex and gaps
  • Use Button component instead of IconButton

Before
CleanShot 2024-03-08 at 10 24 29@2x

NOTE: The "Clear Selected" button is currently in the hover state in this screenshot, showing the incorrect behavior it has today compared to other buttons.

After
CleanShot 2024-03-08 at 10 23 58@2x

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kmcginnes kmcginnes marked this pull request as ready for review March 8, 2024 16:39
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 10.95%. Comparing base (33e7e2f) to head (ca31840).

Files Patch % Lines
...plorer/src/modules/KeywordSearch/KeywordSearch.tsx 0.00% 17 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #260   +/-   ##
=======================================
  Coverage   10.94%   10.95%           
=======================================
  Files         409      409           
  Lines       30421    30417    -4     
  Branches      711      711           
=======================================
  Hits         3331     3331           
+ Misses      26757    26753    -4     
  Partials      333      333           
Flag Coverage Δ
unittests 10.95% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@michaelnchin michaelnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on SageMaker Notebook, appearance and functionality all looks good. Thanks @kmcginnes !

@vkagamlyk vkagamlyk merged commit 122169c into aws:main Mar 14, 2024
2 of 3 checks passed
@kmcginnes kmcginnes deleted the clean-up-search-bottom-ui branch March 19, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants