Single management cluster #431
Conversation
This will introduce a new optional flag (--kubeconfig) that will be used when creating workload clusters. Users will run the following command: eksctl anyhwere create cluster -f workload-cluster-spec.yaml --kuneconfig management.kubeconfig Where "management.kubeconfig" is the kubeconfig file of an existing management cluster. The command above will create a workload cluster. Closes aws#386
The GetMachines() method was previously listing all Machine CRs in the cluster. With the introduction of Workload clusters it is necessary to filter machines using the cluster name
abhay-krishna
added
approved
size/L
| err = fc.writeFluxSystemFiles() | ||
| if err != nil { | ||
| return &ConfigVersionControlFailedError{Err: err} | ||
| if fc.clusterSpec.Spec.Management == nil || !*fc.clusterSpec.Spec.Management { |
There was a problem hiding this comment.
i think we want to treat Spec.Management == nil as management cluster right? if so, we should generate flux manifests.
|
Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiayiwang7, mdsgabriel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
* Allow users to create wokload clusters This will introduce a new optional flag (--kubeconfig) that will be used when creating workload clusters. Users will run the following command: eksctl anyhwere create cluster -f workload-cluster-spec.yaml --kuneconfig management.kubeconfig Where "management.kubeconfig" is the kubeconfig file of an existing management cluster. The command above will create a workload cluster. Closes aws#386 * Use cluster name when listing machines The GetMachines() method was previously listing all Machine CRs in the cluster. With the introduction of Workload clusters it is necessary to filter machines using the cluster name * Fix logic
Issue #, if available:
Description of changes:
Allow users to create workload clusters using an existing management cluster
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.