Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package for feature toggles #342

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Conversation

g-gaston
Copy link
Member

Closes #311

Description of changes:
This adds a little package to manage feature toggles. It uses envvars for now, but it could potentially be expanded to use anything else if necessary (I don't think it will)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@abhay-krishna abhay-krishna added approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 28, 2021
Copy link
Member

@vivek-koppuru vivek-koppuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@abhay-krishna
Copy link
Member

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: g-gaston, vivek-koppuru

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [g-gaston,vivek-koppuru]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhay-krishna abhay-krishna merged commit 293234e into aws:main Sep 30, 2021
rothgar pushed a commit to rothgar/eks-anywhere that referenced this pull request Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature flag package
3 participants