Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about new environment variables #2007

Merged
merged 1 commit into from
May 4, 2022

Conversation

mdsgabriel
Copy link
Member

Issue #, if available:
#1730
Description of changes:
Documentation showing how to configure Cloud Provider and CSI Driver
with separate credentials

Testing (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 4, 2022
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #2007 (8aa2ae4) into main (577036d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2007   +/-   ##
=======================================
  Coverage   49.76%   49.76%           
=======================================
  Files         298      298           
  Lines       25447    25447           
=======================================
  Hits        12664    12664           
  Misses      11464    11464           
  Partials     1319     1319           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 577036d...8aa2ae4. Read the comment docs.

Documentation showing how to configure Cloud Provider and CSI Driver
with separate credentials
@mdsgabriel mdsgabriel force-pushed the optional-vsphere-credentials branch from bb4b788 to 8aa2ae4 Compare May 4, 2022 17:21
Copy link
Member

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 6a20e4b into aws:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants