Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HuggingFace PT Inference/training CVE fix #3523

Merged
merged 31 commits into from
Dec 6, 2023
Merged

Conversation

haixiw
Copy link
Contributor

@haixiw haixiw commented Nov 14, 2023

GitHub Issue #, if available:

Note:

  • If merging this PR should also close the associated Issue, please also add that Issue # to the Linked Issues section on the right.

  • All PR's are checked weekly for staleness. This PR will be closed if not updated in 30 days.

Description

Fixing CVES for Huggingface pytorch inference images

Tests run

NOTE: By default, docker builds are disabled. In order to build your container, please update dlc_developer_config.toml and specify the framework to build in "build_frameworks"

  • I have run builds/tests on commit for my changes.

NOTE: If you are creating a PR for a new framework version, please ensure success of the standard, rc, and efa sagemaker remote tests by updating the dlc_developer_config.toml file:

  • [ x] Revision A: sagemaker_remote_tests = "standard"
  • Revision B: sagemaker_remote_tests = "rc"
  • Revision C: sagemaker_remote_tests = "efa"

All tests passed in the commit : 2716276

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added build Reflects file change in build folder huggingface Reflects file change in huggingface folder Size:XS Determines the size of the PR labels Nov 14, 2023
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added the Size:S Determines the size of the PR label Nov 15, 2023
@haixiw haixiw changed the title HuggingFace Inference CVE fix HuggingFace PT training/Inference CVE fix Nov 15, 2023
@haixiw haixiw changed the title HuggingFace PT training/Inference CVE fix HuggingFace PT Inference CVE fix Nov 19, 2023
@haixiw haixiw changed the title HuggingFace PT Inference CVE fix HuggingFace PT Inference/training CVE fix Nov 21, 2023
@haixiw haixiw marked this pull request as ready for review November 21, 2023 23:58
@haixiw haixiw requested review from a team as code owners November 21, 2023 23:58
@haixiw haixiw requested review from amzn-choeric and a team November 22, 2023 00:00
Copy link
Contributor

@chrstfu chrstfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, I believe we need to change the release yaml to release the images?

@tejaschumbalkar tejaschumbalkar merged commit 75116c9 into master Dec 6, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Reflects file change in build folder huggingface Reflects file change in huggingface folder Size:S Determines the size of the PR Size:XS Determines the size of the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants