fix(lib-storage): chunk from readable only when defined #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1886 +/- ##
=======================================
Coverage 79.30% 79.31%
=======================================
Files 368 368
Lines 15132 15157 +25
Branches 3222 3236 +14
=======================================
+ Hits 12001 12022 +21
- Misses 3131 3135 +4
Continue to review full report at Codecov.
|
trivikr
reviewed
Jan 8, 2021
trivikr
approved these changes
Jan 8, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AllanZhengYP
approved these changes
Jan 8, 2021
alexforsyth
changed the title
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Unit tests for
lib/storageare broken on node 12+, they work in node 10. The root cause is a minor difference in how readable works in node 12+.Description of changes:
The functionality of readable differs slightly between node 10 and node 12+. This results in
stream.on("end", () => {listener never being called in node 12+ but always being called in node 10. Due to this, chunking never actually ends in node 12+. The unit tests catch this and complain when being run in node 12+.I've fixed the code to rely on
streamreader.readablefor end-state. This should work in both node 10 and node 12+ now.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.