aws/ec2metadata: Reduces timeout and number of max retries for EC2Metadata client
#3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotambkar
added
pr/work-in-progress
jasdel
approved these changes
Jan 7, 2020
skotambkar
changed the title
aws/ec2metadata: Reduces timeout and number of max retries for EC2Metadata client
aws-sdk-go-automation
pushed a commit
that referenced
this pull request
Jan 7, 2020
=== ### Service Client Updates * `service/AWSMigrationHub`: Updates service API, documentation, and paginators * `service/codebuild`: Updates service API and documentation * Add encryption key override to StartBuild API in AWS CodeBuild. * `service/xray`: Updates service documentation * Documentation updates for xray ### SDK Enhancements * `aws`: Add configuration option enable the SDK to unmarshal API response header maps to normalized lower case map keys. ([#3033](#3033)) * Setting `aws.Config.LowerCaseHeaderMaps` to `true` will result in S3's X-Amz-Meta prefixed header to be unmarshaled to lower case Metadata member's map keys. ### SDK Bugs * `aws/ec2metadata` : Reduces request timeout for EC2Metadata client along with maximum number of retries ([#3066](#3066)) * Reduces latency while fetching response from EC2Metadata client running in a container to around 3 seconds * Fixes [#2972](#2972)
Merged
aws-sdk-go-automation
added a commit
that referenced
this pull request
Jan 7, 2020
Release v1.27.2 (2020-01-07) === ### Service Client Updates * `service/AWSMigrationHub`: Updates service API, documentation, and paginators * `service/codebuild`: Updates service API and documentation * Add encryption key override to StartBuild API in AWS CodeBuild. * `service/xray`: Updates service documentation * Documentation updates for xray ### SDK Enhancements * `aws`: Add configuration option enable the SDK to unmarshal API response header maps to normalized lower case map keys. ([#3033](#3033)) * Setting `aws.Config.LowerCaseHeaderMaps` to `true` will result in S3's X-Amz-Meta prefixed header to be unmarshaled to lower case Metadata member's map keys. ### SDK Bugs * `aws/ec2metadata` : Reduces request timeout for EC2Metadata client along with maximum number of retries ([#3066](#3066)) * Reduces latency while fetching response from EC2Metadata client running in a container to around 3 seconds * Fixes [#2972](#2972)
ghost
mentioned this pull request
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR address the issues related to EC2Metadata client having long timeouts in case of failure in obtaining EC2Metadata token, while making a request to IMDS.
The PR reduces the timeout to 1 sec, and number of max retries to 2 for the EC2Metadata client. This would help reduce the long timeouts faced by the customers.
Fixes #2972