Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instance limits for upcoming vpc-cni release #2506

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

jchen6585
Copy link
Contributor

What type of PR is this?
enhancement

Which issue does this PR fix:
N/A

What does this PR do / Why do we need it:
Updates the instance pod limits by running make generate-limits. https://github.com/awslabs/amazon-eks-ami/blob/master/files/eni-max-pods.txt is not updated as well so opened up a PR @ awslabs/amazon-eks-ami#1397.

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

N/A

Automation added to e2e:

No

Will this PR introduce any new dependencies?:

No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No

Does this change require updates to the CNI daemonset config files to work?:

No

Does this PR introduce any user-facing change?:

Yes

Update instance limits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jchen6585 jchen6585 requested a review from a team as a code owner August 22, 2023 17:36
@jchen6585 jchen6585 changed the title Update instance limits upcoming vpc-cni release Update instance limits for upcoming vpc-cni release Aug 22, 2023
Copy link
Contributor

@jdn5126 jdn5126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, this is a lot of instances. Thanks for updating!

@jdn5126 jdn5126 merged commit 6e79093 into aws:master Aug 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants